byGalax/ChatApp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(desktop): voice hotkeys are window-scoped unless Global is toggled

Browse Source 
The old code registered every enabled hotkey through Electron globalShortcut
API, which captures system-wide. Setting M as mute meant m could not be
typed in any other app. Now the OS-level registration only happens when
binding.global === true; otherwise the existing window-keydown listener
handles it.
This commit is contained in:
byGalax
2026-05-16 16:41:20 +02:00
parent 8c27e8eafa
commit ca77214e2d
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/desktop/src/context/CallContext.tsx
+9 -7
View File
@@ -2004,14 +2004,16 @@ export function CallProvider({ children }: { children: ReactNode }) {
const syncGlobalShortcuts = () => { const syncGlobalShortcuts = () => {
if (!isTauriRuntime()) return; if (!isTauriRuntime()) return;
// Only register an OS-level shortcut if the user explicitly opted in.
// Window-scoped firing happens via the `onKey` listener above and works
// for every enabled binding regardless of the `global` flag.
const enabledAndGlobal = (b: VoiceHotkeys[HotkeyKind]) => b.enabled && b.global;
const desired: Record<HotkeyKind, string | null> = { const desired: Record<HotkeyKind, string | null> = {
mute: settings.mute.enabled ? bindingToTauriShortcut(settings.mute) : null, mute: enabledAndGlobal(settings.mute) ? bindingToTauriShortcut(settings.mute) : null,
deafen: settings.deafen.enabled ? bindingToTauriShortcut(settings.deafen) : null, deafen: enabledAndGlobal(settings.deafen) ? bindingToTauriShortcut(settings.deafen) : null,
hangup: settings.hangup.enabled ? bindingToTauriShortcut(settings.hangup) : null, hangup: enabledAndGlobal(settings.hangup) ? bindingToTauriShortcut(settings.hangup) : null,
screenShare: settings.screenShare.enabled screenShare: enabledAndGlobal(settings.screenShare) ? bindingToTauriShortcut(settings.screenShare) : null,
? bindingToTauriShortcut(settings.screenShare) video: enabledAndGlobal(settings.video) ? bindingToTauriShortcut(settings.video) : null,
: null,
video: settings.video.enabled ? bindingToTauriShortcut(settings.video) : null,
}; };
for (const kind of KINDS) { for (const kind of KINDS) {
const want = desired[kind]; const want = desired[kind];