Compare commits

..

3 Commits

Author SHA1 Message Date
byGalax f438018400 chore(desktop): release v0.21.11 2026-06-02 23:07:34 +02:00
byGalax 89003f71a4 fix(desktop): remove chat-switch reveal flicker (decouple from reactions)
The residual flicker on chat switch was a loading/reveal artifact, not scroll.
listReady gated the MessageList reveal on reactionsReady OR a 300ms timeout, so
on a cache-hit switch (messages already present from the first render) the list
sat at opacity:0 for up to 300ms and then popped in. Drop the reactions/timeout
gate: reveal as soon as messages exist. Reaction chips stream in a beat later;
because the list is pinned to the bottom their height growth re-pins with no
visible jump, and MessageList still defers its own reveal a few frames until the
row-height measurement settles so it appears already at the final bottom.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-02 23:02:07 +02:00
byGalax b364c53c61 fix(desktop): degrade missing avatar image to letter circle
Avatar rendered a bare <img> with no error handling, so an avatar_url whose
storage object is unreachable (e.g. a 404 after the server move) showed a
broken image instead of the coloured letter-circle fallback. Track an onError
flag and fall back to the circle; reset it when the URL changes so a fresh
valid avatar is retried. This is client-side resilience only — it does not
restore a genuinely missing storage object.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-02 23:02:07 +02:00
3 changed files with 21 additions and 15 deletions
+1 -1
View File
@@ -1,6 +1,6 @@
{ {
"name": "@chat-app/desktop", "name": "@chat-app/desktop",
"version": "0.21.10", "version": "0.21.11",
"private": true, "private": true,
"description": "Electron desktop client (Windows / macOS / Linux)", "description": "Electron desktop client (Windows / macOS / Linux)",
"type": "module", "type": "module",
+10 -1
View File
@@ -1,6 +1,8 @@
// Reusable avatar that prefers an uploaded image and falls back to a coloured // Reusable avatar that prefers an uploaded image and falls back to a coloured
// letter circle. Use this everywhere the app needs to render a profile. // letter circle. Use this everywhere the app needs to render a profile.
import { useEffect, useState } from 'react';
import { useCachedAvatarUrl } from '../lib/avatarCache'; import { useCachedAvatarUrl } from '../lib/avatarCache';
interface Props { interface Props {
@@ -27,7 +29,13 @@ export function Avatar({
loading = 'lazy', loading = 'lazy',
}: Props) { }: Props) {
const effectiveUrl = useCachedAvatarUrl(url); const effectiveUrl = useCachedAvatarUrl(url);
if (effectiveUrl) { // If the image URL is non-empty but unreachable (e.g. the storage object is
// missing / 404s), the bare <img> would render broken with no fallback.
// Track a load error and degrade to the letter circle instead. Reset on URL
// change so a fresh, valid avatar is retried.
const [failed, setFailed] = useState(false);
useEffect(() => setFailed(false), [effectiveUrl]);
if (effectiveUrl && !failed) {
return ( return (
<img <img
src={effectiveUrl} src={effectiveUrl}
@@ -35,6 +43,7 @@ export function Avatar({
className={'shrink-0 rounded-full object-cover ' + className} className={'shrink-0 rounded-full object-cover ' + className}
draggable={false} draggable={false}
loading={loading} loading={loading}
onError={() => setFailed(true)}
/> />
); );
} }
+10 -13
View File
@@ -144,21 +144,18 @@ export function ConversationPage() {
byMessage: reactionsByMessage, byMessage: reactionsByMessage,
toggle: toggleReaction, toggle: toggleReaction,
voteExclusive: votePoll, voteExclusive: votePoll,
ready: reactionsReady,
} = useMessageReactions(messageIds, session?.user.id); } = useMessageReactions(messageIds, session?.user.id);
// Deferred-reveal gate for MessageList: keep the list hidden until messages // Reveal gate for MessageList: as soon as messages exist (cache hit = first
// AND their reactions (the main post-paint height changer) are loaded, so the // render, so no spinner and no wait), let the list reveal. We deliberately do
// chat opens already-stable instead of flickering through the load cascade. // NOT gate on reactions readiness: on a cache-hit chat switch the messages are
// A 300 ms max-timeout ensures a slow/empty reactions fetch never hangs it. // already present, and gating on the async reactions fetch held the list at
const [revealTimedOut, setRevealTimedOut] = useState(false); // opacity:0 for up to 300ms and then "popped" it in — that was the residual
useEffect(() => { // chat-switch flicker. Reaction chips stream in a beat later; because the list
setRevealTimedOut(false); // is pinned to the bottom, their height growth re-pins with no visible jump.
if (!id || loading || messages.length === 0) return; // MessageList still defers its own reveal a few frames until the row-height
const tmo = window.setTimeout(() => setRevealTimedOut(true), 300); // measurement settles, so the list still appears already at the final bottom.
return () => window.clearTimeout(tmo); const listReady = !loading && messages.length > 0;
}, [id, loading, messages.length]);
const listReady = !loading && messages.length > 0 && (reactionsReady || revealTimedOut);
const myId = session?.user.id; const myId = session?.user.id;